-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include NOTICE file in npm published package and in dist #2764
Conversation
The NOTICE file in the distribution includes the license for all the bundled packages (i.e. add dependencies, excluding devDependencies). Creating the distribution (dev-utils/make-distribution.sh) will fail if one of the deps has no license or an unknown license.
Here is an example generated NOTICE file: https://gist.github.com/trentm/057ec6b14669a6b02562581756a362d9 |
…nse text file in their install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- one question on case sensitivity and I think we'll be good to go.
…; also add 'npm run lint:license-files' so that lint fails if a new dep doesn't have a license or license file that will be needed for release
…I linting node versions to v16 for npm@8 to run 'npm run lint:license-files'
…lder versions of node and get a warning, not a hard failure (this is the same behaviour as our eslint linting)
@astorm CI passing again. I've added a |
The NOTICE file in the distribution includes the license for all
the bundled packages (i.e. add dependencies, excluding devDependencies).
Creating the distribution (dev-utils/make-distribution.sh) will fail
if one of the deps has no license or an unknown license.