New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mysql2 3.x.x function #3301
Conversation
💚 CLA has been signed |
@firecow Thanks for the PR! I'm looking now. I hope you are okay with me pushing some tweaks to your branch. For example, it looks like your PR changed the package-lock.json to Windows line endings which artificially makes it look like a 27k line diff. :) |
@firecow Are you able to sign our CLA? (See #3301 (comment).) |
Finding what versions of node mysql2 supports is a little interesting. It has:
however:
|
Attempting with node 8.6 crashes in lru-cache.
Similarly with node v12:
It seems to work with node 14.6.0 (crashes with node 14.5.0). The lru-cache min dep on node v16.14 was added for specifics of its abort handling (isaacs/node-lru-cache@b3b6d24). From a quick grep it doesn't look like node-mysql2 is using any "Abort"-related support in its usage of lru-cache. So at a guess, node 14 is the effective min supported node version. |
@elasticmachine, run elasticsearch-ci/docs |
Thanks, @firecow! |
You are welcome, and thank you for maintaining this project 🤟 |
…re/support-specific-modules * 'main' of github.com:elastic/apm-agent-nodejs: (54 commits) chore: fix dev-utils/ci-tav-slow-jobs.sh (elastic#3319) test: reduce TAV test matrix for slowest jobs (elastic#3321) chore: sync package-lock so 'npm ci' can work (elastic#3318) docs: document `useElasticTraceparentHeader` config var (elastic#3316) chore, test: test driver improvements (elastic#3293) test: drop node 14 from RC tests now that it is EOL (elastic#3315) test: fix running fastify.test.js with node v8 (elastic#3317) feat: add @apollo/server@4 support (elastic#3203) chore: update nvm (elastic#3309) tests: stop testing 'express-graphql' instrumentation (elastic#3304) chore: fix bitrot.js dev util for recent changes (elastic#3308) test: restore testing of Azure Functions on node >=18.x (elastic#3307) fix: support Lambda instrumentation for `contextManager: 'patch'`; refactor Lambda tests (elastic#3305) test: fix fastify TAV test failures (elastic#3314) test: fix @aws-sdk/client-s3 TAV test failures (elastic#3312) feat: add instrumentation for aws-sdk S3 client (elastic#3287) feat(fastify): add captureBody support (elastic#2681) feat: mysql2@3 support (elastic#3301) chore(deps): bump @opentelemetry/exporter-prometheus from 0.37.0 to 0.38.0 in /test/opentelemetry-metrics/fixtures (elastic#3295) chore(deps-dev): bump fastify from 4.16.3 to 4.17.0 (elastic#3296) ...
mysql2@3 doesn't appear to contain any changes to createConnection, query, or execute -- the exports that are instrumented. Fixes: #3151 Co-authored-by: Trent Mick <trent.mick@elastic.co>
From what I can tell, mysql 3.x.x doesn't contain any changes to createConnection, query or execute.
Fixes: #3151
Checklist