Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, refactor: simplify pg.test.js #3392

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

trentm
Copy link
Member

@trentm trentm commented May 29, 2023

Node.js has had native Promise since v0.12.

Review suggestion: Ignore whitespace for a smaller diff: https://github.com/elastic/apm-agent-nodejs/pull/3392/files?w=1

Node.js has had native Promise since v0.12.
@trentm trentm requested a review from david-luna May 29, 2023 21:29
@trentm trentm self-assigned this May 29, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 29, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) May 29, 2023
trentm added a commit that referenced this pull request May 29, 2023
Refs: #3392 (to merge this independently)
@trentm trentm merged commit 5c372b6 into main May 31, 2023
36 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done May 31, 2023
@trentm trentm deleted the trentm/refactor-pg-tests-promise branch May 31, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants