-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mongodb connection pool patch #3665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
trentm
previously approved these changes
Oct 13, 2023
Ah, I reviewed quickly and hasn't noticed the test failures:
I assume that is an easy fix. |
The effects of search & replace if your search term is not accurate enough 😅 |
david-luna
commented
Oct 16, 2023
test/instrumentation/modules/mongodb/fixtures/use-mongodb-async-context.js
Outdated
Show resolved
Hide resolved
trentm
previously approved these changes
Oct 16, 2023
test/instrumentation/modules/mongodb/fixtures/use-mongodb-async-context.js
Outdated
Show resolved
Hide resolved
trentm
approved these changes
Oct 17, 2023
trentm
pushed a commit
that referenced
this pull request
Oct 18, 2023
The recent refactor of mongodb.test.js missed handling the MONGODB_HOST env var used in Docker tests. Refs: #3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches Mongodb's
ConectionPool
class to ensure the context is not lost when queueing the commands. The agent makes use of theAsyncLocalStiorage.bind
static function to inject the context into the queued callbacks.The PR also migrates to the new test implementations making use of
runTestFixtures
util.Fixes #3161
NOTE: its a replica from #3657 to omit all the conversation that produced the new patch registry in #3658
Checklist