-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mongodb): resolve collections for command #3919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav mongodb
TAV tests reveal we have the context issue also for running npm run docker:start mongodb
node ./test/instrumentation/modules/mongodb/fixtures/use-mongodb-async-context.js gives the following traces
|
So just skip that test for those early early versions, right? No need to accommodate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test tav mongodb
MongoDb cursors spawn some extra commands when the list of documents to
find
is big enough. In particular the command is namesgetMore
and the shape of the command is a bit different than the known ones (insert, find, delete, ...)This PR seeks for a specific property within the
getMore
command payload to resolve the collection name and use it to create the name of the corresponding span. Tests have been modified accordingly to check for the proper span naming.Kudos to @sibelius to propose that change
Closes: #3834
Checklist