Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch @smithy/smithy-client@3 for release @aws-sdk/client-* releases #4036

Merged
merged 4 commits into from
May 31, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented May 21, 2024

Recently @aws-sdk/client-* releases started using v3 of smithy/smithy-client.
This updates our instr to allow patching v3.

…ases

Recently @aws-sdk/client-* releases started using v3 of smithy/smithy-client.
This updates our instr to allow patching v3.
@trentm trentm requested a review from david-luna May 21, 2024 19:16
@trentm trentm self-assigned this May 21, 2024
@trentm
Copy link
Member Author

trentm commented May 21, 2024

The symptom was that @aws-sdk/client-* TAV tests started failing on all Node.js versions.
Note that the smithy-client v3 update dropped Node.js 14.x support (see aws/aws-sdk-js-v3#6088), so we may have to restrict node v14 testing with newer client-* releases.

@trentm
Copy link
Member Author

trentm commented May 21, 2024

/test tav @aws-sdk/client-s3,@aws-sdk/client-dynamodb,@aws-sdk/client-sns,@aws-sdk/client-sqs

Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @aws-sdk/client-s3,@aws-sdk/client-dynamodb,@aws-sdk/client-sns,@aws-sdk/client-sqs

@trentm trentm requested a review from a team May 21, 2024 20:31
@trentm
Copy link
Member Author

trentm commented May 23, 2024

The Node.js 14 TAV tests passed for now. It may (will likely) break in the future.

@trentm trentm requested a review from estolfo May 27, 2024 17:00
estolfo
estolfo previously approved these changes May 28, 2024
@trentm trentm merged commit ec2f58e into main May 31, 2024
18 checks passed
@trentm trentm deleted the trentm/fix-aws-sdk-smithy-client-v3 branch May 31, 2024 16:16
@trentm trentm mentioned this pull request Jun 4, 2024
1 task
trentm added a commit that referenced this pull request Jun 5, 2024
…ases (#4036)

Recently @aws-sdk/client-* releases started using v3 of smithy/smithy-client.
This updates our instr to allow patching v3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants