Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ids to correct v2 api format #584

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Conversation

watson
Copy link
Contributor

@watson watson commented Sep 14, 2018

All the new id's are hex encoded random numbers. Their sizes are:

  • error id: 128 bit
  • transaction id: 64 bit
  • span id: 64 bit
  • trace id: 128 bit

The implemented id generator is temporary (except error id's) and will be replaced by the OpenTracing id engine once that lands.

Checklist

  • Implement code
  • Add tests

All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
@watson
Copy link
Contributor Author

watson commented Sep 14, 2018

My original idea was to wait with this until #538 was merged, but I needed the trace-id's in order to make #585

Copy link
Contributor

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this isn't too painful to rebase into the distributed tracing PR. Feel free to land anyway though. 😅

lib/agent.js Show resolved Hide resolved
@watson watson merged commit 8d800b3 into elastic:api-v2 Sep 18, 2018
@watson watson deleted the v2-ids branch September 18, 2018 16:25
watson added a commit that referenced this pull request Oct 19, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Oct 27, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
Qard pushed a commit that referenced this pull request Oct 31, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 6, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit that referenced this pull request Nov 6, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
Qard pushed a commit that referenced this pull request Nov 8, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit that referenced this pull request Nov 10, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
All the new id's are hex encoded random numbers. Their sizes are:

- error id: 128 bit
- transaction id: 64 bit
- span id: 64 bit
- trace id: 128 bit

The implemented id generator is temporary (except error id's) and will
be replaced by the OpenTracing id engine once that lands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants