Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add v2 upgrade guide #631

Merged
merged 1 commit into from
Oct 23, 2018
Merged

docs: add v2 upgrade guide #631

merged 1 commit into from
Oct 23, 2018

Conversation

watson
Copy link
Contributor

@watson watson commented Oct 23, 2018

This page is similar to the one we made for upgrading to v1.

When rendered, the page looks like this:

screencapture-file-users-watson-code-node_modules-elastic-apm-node-build-html_docs-apm-agent-nodejs-upgrade-to-v2-html-2018-10-23-15_34_52

This PR also adds a link to the page to the Upgrading page:

image

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine and the structure looks good to me. Just a few nitpicky grammar changes I'd recommend.

docs/upgrade-to-v2.asciidoc Outdated Show resolved Hide resolved
docs/upgrade-to-v2.asciidoc Outdated Show resolved Hide resolved
docs/upgrade-to-v2.asciidoc Outdated Show resolved Hide resolved
docs/upgrade-to-v2.asciidoc Outdated Show resolved Hide resolved
@watson
Copy link
Contributor Author

watson commented Oct 23, 2018

Fixed

@watson watson merged commit 08c5e60 into elastic:api-v2 Oct 23, 2018
@watson watson deleted the v2-upgrade-docs branch October 23, 2018 16:48
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Oct 27, 2018
Qard pushed a commit that referenced this pull request Oct 31, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 6, 2018
watson added a commit that referenced this pull request Nov 6, 2018
Qard pushed a commit that referenced this pull request Nov 8, 2018
watson added a commit that referenced this pull request Nov 10, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants