fix: we don't support mongodb-core v3.1.10+ #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.1.10 of mongodb-core removed the _find method that we depended upon to start new spans. Until we find a workaround for this, we'll have to drop support for this and newer versions.
|
jenkins, retest this please |
|
jenkins, retest this please |
1 similar comment
|
jenkins, retest this please |
|
I'm going to just land this. The test failures on jenkins are unrelated, and the Travis tests are validation enough. It'll help with other PRs to get this fixed. |
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Jan 17, 2019
Version 3.1.10 of mongodb-core removed the _find method that we depended upon to start new spans. Until we find a workaround for this, we'll have to drop support for this and newer versions.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Jan 17, 2019
Version 3.1.10 of mongodb-core removed the _find method that we depended upon to start new spans. Until we find a workaround for this, we'll have to drop support for this and newer versions.
watson
added a commit
that referenced
this pull request
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.1.10 of mongodb-core removed the _find method that we depended upon to start new spans. Until we find a workaround for this, we'll have to drop support for this and newer versions.