[packaging] support multiple PHP API #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
force-pushed
the
feature/support-multiple-versions
branch
from
86b26c2
to
34870cb
Compare
v1v
force-pushed
the
feature/support-multiple-versions
branch
from
34870cb
to
9230888
Compare
v1v
commented
Aug 11, 2020
.ci/Jenkinsfile
Outdated
Comment on lines
117
to
119
| unstash 'generate-7.2' | ||
| unstash 'generate-7.3' | ||
| unstash 'generate-7.4' |
There was a problem hiding this comment.
I'd say this is not ideal, although we could potentially use something else to simplify where the generated so files are stored
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
v1v
force-pushed
the
feature/support-multiple-versions
branch
from
01d82fa
to
101901c
Compare
v1v
commented
Aug 11, 2020
| RUN apt-get -qq update \ | ||
| && apt-get -qq install -y procps --no-install-recommends \ | ||
| && apt-get -qq install -y git procps zlib1g-dev libzip-dev unzip --no-install-recommends \ |
There was a problem hiding this comment.
Required dependencies when running composer install without any cached dependencies
v1v
commented
Aug 11, 2020
Comment on lines
+13
to
+17
| ## sh: git: command not found | ||
| # the zip extension and unzip command are both missing, skipping. | ||
| RUN yum update -y \ | ||
| && yum install -y git unzip \ | ||
| && yum clean all |
There was a problem hiding this comment.
SergeyKleyman
approved these changes
Aug 12, 2020
v1v
added a commit
to v1v/apm-agent-php
that referenced
this pull request
Aug 18, 2020
* upstream/master: Add ENVIRONMENT configuration option Change composer installation in docker (elastic#128) Add tests/APM_Agents_shared directory [packaging] support multiple PHP API (elastic#121) [Packaging] restore php.ini if something bad happened (elastic#116) [CI] Cosmetic changes in the stage names (elastic#115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
installmake goal has been deleted since it's already done when runningmake -C packaging deb-installcleanmake goal to tear down the generated packages folder.composer installin the docker containers.Tasks
Issues
Closes #113
Closes #114
Tests
How to test it locally?
Improvements
matrixapproach