Skip to content

Commit

Permalink
ci: use v3 artifact APIs for build-distribution (#2046)
Browse files Browse the repository at this point in the history
Hopefully fix:
The lambda layer can be published as follows for dev work:
    aws lambda --output json publish-layer-version --layer-name 'runner-dev-elastic-apm-python' --description 'runner dev Elastic APM Python agent lambda layer' --zip-file 'fileb://build/dist/elastic-apm-python-lambda-layer.zip'
Run actions/upload-artifact@v4
  with:
    name: build-distribution
    path: ./build/
    if-no-files-found: error
    compression-level: 6
    overwrite: false
  env:
    ...
With the provided path, there will be 636 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
  • Loading branch information
xrmx committed May 17, 2024
1 parent 62448d3 commit a69528b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/actions/build-distribution/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
run: ./dev-utils/make-distribution.sh
shell: bash

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: build-distribution
path: ./build/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
secrets: |
secret/observability-team/ci/service-account/apm-agent-python access_key_id | AWS_ACCESS_KEY_ID ;
secret/observability-team/ci/service-account/apm-agent-python secret_access_key | AWS_SECRET_ACCESS_KEY
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: build-distribution
path: ./build
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
roleId: ${{ secrets.VAULT_ROLE_ID }}
secretId: ${{ secrets.VAULT_SECRET_ID }}

- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
with:
name: build-distribution
path: ./build
Expand Down

0 comments on commit a69528b

Please sign in to comment.