Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include authorization http header in mask fields #274

Closed
naviens opened this issue Aug 28, 2018 · 1 comment
Closed

Include authorization http header in mask fields #274

naviens opened this issue Aug 28, 2018 · 1 comment

Comments

@naviens
Copy link

naviens commented Aug 28, 2018

In REST based token authentication auth token was sent via http authorization which need to be masked.
@naviens naviens changed the title Include authorization http header in mask fields Include authorization http header in mask fields Aug 28, 2018
@naviens naviens changed the title Include authorization http header in mask fields Include authorization http header in mask fields Aug 28, 2018
@beniwohli
Copy link
Contributor

Hi @naviens! Excellent point, and sort of embarrassing that we didn't have it in the default sanitization list since forever. I'll add it ASAP.

Ideally, we should probably make this list extendable via configuration, but that can wait for a later release.

beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Aug 29, 2018
@beniwohli
make sure to filter authorization headers
8201c1f 
closes elastic#274
@beniwohli beniwohli mentioned this issue Aug 29, 2018
Closed
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Aug 30, 2018
@beniwohli
make sure to filter authorization headers
9d1107f 
closes elastic#274
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure to filter authorization headers beniwohli/apm-agent-python
3 participants
@beniwohli @naviens @alvarolobato