Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture request body for more Elasticsearch APIs #419

Closed
axw opened this issue Mar 12, 2019 · 0 comments · Fixed by #1013
Closed

Capture request body for more Elasticsearch APIs #419

axw opened this issue Mar 12, 2019 · 0 comments · Fixed by #1013
Assignees
@beniwohli
Labels
agent-python

Comments

@axw
Copy link
Member

axw commented Mar 12, 2019

See elastic/apm#55
@axw axw mentioned this issue Mar 12, 2019
Closed
@beniwohli beniwohli self-assigned this Jan 20, 2021
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Jan 20, 2021
@beniwohli
align elasticsearch body capturing with other agents
ba472f7 
See elastic/apm#55

This also allows us to get rid of a hack we used to pass the API method
and an unserialized version of the body to the instrumentation. Neither
is used anymore, so we can skip that part of the instrumentation.

This does also mean that we stop capturing the body for some methods,
specifically `update` and `delete_by_query`.

closes elastic#419
@beniwohli beniwohli mentioned this issue Jan 20, 2021
Merged
basepi added a commit that referenced this issue Jan 28, 2021
@beniwohli @basepi
align elasticsearch body capturing with other agents (#1013)
d2e9cd4 
* align elasticsearch body capturing with other agents

See elastic/apm#55

This also allows us to get rid of a hack we used to pass the API method
and an unserialized version of the body to the instrumentation. Neither
is used anymore, so we can skip that part of the instrumentation.

This does also mean that we stop capturing the body for some methods,
specifically `update` and `delete_by_query`.

closes #419

* fix test code

using params=None never made sense here

* update path matching regex to align with Node.js agent

* Add CHANGELOG

Co-authored-by: Colton Myers <colton.myers@gmail.com>
@zube zube bot removed the [zube]: Done label Apr 29, 2021
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Sep 14, 2021
@beniwohli @basepi
align elasticsearch body capturing with other agents (elastic#1013)
b100e8a 
* align elasticsearch body capturing with other agents

See elastic/apm#55

This also allows us to get rid of a hack we used to pass the API method
and an unserialized version of the body to the instrumentation. Neither
is used anymore, so we can skip that part of the instrumentation.

This does also mean that we stop capturing the body for some methods,
specifically `update` and `delete_by_query`.

closes elastic#419

* fix test code

using params=None never made sense here

* update path matching regex to align with Node.js agent

* Add CHANGELOG

Co-authored-by: Colton Myers <colton.myers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beniwohli beniwohli

Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

align elasticsearch body capturing with other agents beniwohli/apm-agent-python
4 participants
@beniwohli @basepi @axw @alvarolobato