Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Starlette middleware - providing only static files #1137

Merged
merged 8 commits into from Jun 30, 2021
Merged

Fix Starlette middleware - providing only static files #1137

merged 8 commits into from Jun 30, 2021

Conversation

Sparkycz
Copy link
Contributor

What does this pull request do?

Starlette can provide also static files but when a developer defined routes only for static files the middleware crashed.

Related issues

closes #1131

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) May 26, 2021
@apmmachine
Copy link
Collaborator

apmmachine commented May 26, 2021 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1137 updated

  • Start Time: 2021-06-30T18:24:41.567+0000

  • Duration: 30 min 1 sec

  • Commit: b7c4d6f

Test stats 🧪

Test Results
Failed 0
Passed 9481
Skipped 8604
Total 18085

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9481
Skipped 8604
Total 18085

@AlexanderWert AlexanderWert moved this from In Progress to Planned in APM-Agents (OLD) Jun 9, 2021
basepi
basepi approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, let me just double check with @beniwohli and we'll get this merged!

@basepi basepi requested a review from beniwohli June 10, 2021 17:36
@basepi basepi mentioned this pull request Jun 30, 2021
Closed
@basepi basepi merged commit 9d598ce into elastic:master Jun 30, 2021
APM-Agents (OLD) automation moved this from Planned to Done Jun 30, 2021
@basepi basepi mentioned this pull request Jul 12, 2021
Merged
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@Sparkycz @beniwohli @basepi
Fix Starlette middleware - providing only static files (elastic#1137)
1ea7d9e 
* Fix Starlette middleware - providing only static files

closes elastic#1131

* Fix failing tests

* CHANGELOG

Co-authored-by: Benjamin Wohlwend <beni@elastic.co>
Co-authored-by: Colton Myers <colton.myers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

@beniwohli beniwohli Awaiting requested review from beniwohli

Assignees
No one assigned
Labels
agent-python
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on starlette middleware in mount endpoints (StaticFiles)
4 participants
@Sparkycz @apmmachine @basepi @beniwohli