added configuration options for collecting local variables and source code #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
feature/frame-collection-settings
branch
3 times, most recently
from
1793e36
to
3626e84
Compare
simitt
reviewed
Dec 18, 2017
| |============ | ||
| | Environment | Django/Flask | Default | ||
| | `ELASTIC_APM_COLLECT_SOURCE` | `COLLECT_SOURCE` | `all` | ||
| |============ |
There was a problem hiding this comment.
Why did you choose all as default? The note states that this can have a sever overhead, so I personally would expect either none or errors as default here.
There was a problem hiding this comment.
Because we want to have the "full experience" out of the box.
I'm not sure how severe the overhead is tbh, now that we have an LRU cache in front of it. Needs some testing I guess
… code this allows to enable/disable collecting of local variables and source code independent from each other, for exceptions/logs and transactions
beniwohli
force-pushed
the
feature/frame-collection-settings
branch
from
3626e84
to
cfbbcc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows to enable/disable collecting of local variables and source code independent from each other, for exceptions/logs and transactions