fix shortening of local vars #130
Conversation
beniwohli
force-pushed
the
limit-local-var-length
branch
2 times, most recently
from
a0cace4
to
44c1126
Compare
beniwohli
changed the title
|
One issue with this is that it doesn't handle dicts with lots of entries. I'm not sure how we could handle this correctly, due to insertion order not being preserved previous to Python 3.6. So we can't add a |
|
we used to handle it by sorting the keys and then only taking the first X number of items |
| @@ -413,16 +418,21 @@ def _build_msg_for_logging(self, event_type, date=None, context=None, custom=Non | |||
| log = event_data.get('log', {}) | |||
| if stack and 'stacktrace' not in log: | |||
| if stack is True: | |||
| frames = stacks.iter_stack_frames() | |||
| frames = stacks.iter_stack_frames(skip=3) | |||
There was a problem hiding this comment.
It's a bug I noticed when looking at the frames in the test. It included some frames from the agent, so the first frame wasn't where you actually had the logger call.
I suspect there are more issues with too many frames in other places we collect them, but I'll leave that for another PR.
| else: | ||
| ret = func(name, var) | ||
| del context[objid] | ||
| context.remove(objid) | ||
| return ret |
There was a problem hiding this comment.
instead of the change on line 43 and instead of the else clause here, could this just be:
return func(name, var)
?
There was a problem hiding this comment.
that would run func on dict as well. Which isn't entirely wrong, but shorten doesn't have support for dicts yet. I'll try to add support for dict in shorten in a different PR and will change it to your suggested logic one that's in place
beniwohli
force-pushed
the
limit-local-var-length
branch
from
44c1126
to
c9048f1
Compare
This adds configuration option for shortening local variables, as well as a fix for shortening lists