Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only try to decode aioredis command if it is a bytes object #1308

Merged
merged 5 commits into from Aug 30, 2021
Merged

only try to decode aioredis command if it is a bytes object #1308

merged 5 commits into from Aug 30, 2021

Conversation

beniwohli
Copy link
Contributor

fixes #1307

@beniwohli beniwohli requested a review from basepi August 25, 2021 08:55
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Aug 25, 2021
@beniwohli beniwohli mentioned this pull request Aug 25, 2021
Closed
@apmmachine
Copy link
Collaborator

apmmachine commented Aug 25, 2021 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-30T13:49:38.522+0000

  • Duration: 31 min 44 sec

  • Commit: 368ff37

Test stats 🧪

Test Results
Failed 0
Passed 9596
Skipped 8604
Total 18200

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9596
Skipped 8604
Total 18200

@basepi
Copy link
Contributor

basepi commented Aug 25, 2021

This needs a CHANGELOG before merging

@apmmachine apmmachine mentioned this pull request Aug 30, 2021
Closed
@beniwohli beniwohli merged commit 7952011 into elastic:master Aug 30, 2021
APM-Agents (OLD) automation moved this from In Progress to Done Aug 30, 2021
@beniwohli beniwohli deleted the fix-1307 branch August 30, 2021 14:59
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@beniwohli
only try to decode aioredis command if it is a bytes object (elastic#…
1bd3598 
…1308)

* only try to decode aioredis command if it is a bytes object

fixes elastic#1307

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees

@beniwohli beniwohli

Labels
agent-python
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aioredis instrumentation: AttributeError: 'str' object has no attribute 'decode'
3 participants
@beniwohli @apmmachine @basepi