refactor context setters, and document them properly #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
context-setters
branch
from
53dd9bb
to
3dbdafd
Compare
simitt
reviewed
Jan 15, 2018
docs/api.asciidoc
Outdated
| @@ -185,8 +185,49 @@ import elasticapm | |||
| elasticapm.set_transaction_data({'billing_amount': product.price * item_count}) | |||
There was a problem hiding this comment.
Is it really still set_transaction_data and not set_context?
| assert message['context']['user'] == {'username': 'foo', 'email': 'foo@example.com', 'id': 42} | ||
| assert message['context']['tags'] == {'foo': 'baz'} | ||
| assert 'a' in transaction.context['custom'] | ||
| assert 'foo' not in transaction.context['custom'] |
There was a problem hiding this comment.
Maybe I am missing it but I don't see a test that checks that you can call the update functions multiple times. as described in the api docs.
There was a problem hiding this comment.
Excellent point, I added some tests :)
beniwohli
force-pushed
the
context-setters
branch
2 times, most recently
from
4c326bb
to
4abd829
Compare
beniwohli
force-pushed
the
context-setters
branch
from
4abd829
to
9e0ac2e
Compare
beniwohli
added a commit
that referenced
this pull request
Jan 15, 2018
This also adds functionality to copy transaction context data to errors that happen during the transaction. closes #133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds functionality to copy transaction context data to errors that happen during the transaction.