-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings agent alignment #145
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
settings-agent-alignment
branch
from
January 25, 2018 16:08
8da12a9
to
30fe724
Compare
beniwohli
force-pushed
the
settings-agent-alignment
branch
from
January 25, 2018 17:06
e79bc14
to
70de35f
Compare
watson
approved these changes
Jan 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't verified all the Python code in details as I'm probably not the best person to do that, but the names of the new config options are 👍
beniwohli
force-pushed
the
settings-agent-alignment
branch
from
January 25, 2018 17:38
70de35f
to
8e4143a
Compare
beniwohli
added a commit
that referenced
this pull request
Jan 26, 2018
* removed `collect_source` setting, it is replaced by more fine grained * settings * renamed setting `disable_instrumentation` to `instrument` and inverted * meaning * remove `keyword_max_length` setting and hard-code it * renamed `max_event_queue_length` to `max_queue_size` * renamed source line settings variables * renamed `timeout` to `server_timeout` * renamed `transaction_send_frequency` to `flush_interval` closes #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.