Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings agent alignment #145

Closed
wants to merge 9 commits into from

Conversation

beniwohli
Copy link
Contributor

No description provided.

Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified all the Python code in details as I'm probably not the best person to do that, but the names of the new config options are 👍

@beniwohli beniwohli closed this in d256f2a Jan 26, 2018
beniwohli added a commit that referenced this pull request Jan 26, 2018
* removed `collect_source` setting, it is replaced by more fine grained
* settings
* renamed setting `disable_instrumentation` to `instrument` and inverted
* meaning
* remove `keyword_max_length` setting and hard-code it
* renamed `max_event_queue_length` to `max_queue_size`
* renamed source line settings variables
* renamed `timeout` to `server_timeout`
* renamed `transaction_send_frequency` to `flush_interval`

closes #145
@beniwohli beniwohli deleted the settings-agent-alignment branch January 26, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants