use github actions for pre-commit checks #1658
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
beniwohli
force-pushed
the
pre-commit-gh-action
branch
from
f965d59
to
877fcf9
Compare
.pre-commit-config.yaml
Outdated
| - repo: https://gitlab.com/pycqa/flake8 | ||
| rev: 3.8.4 | ||
| rev: 3.9.2 |
There was a problem hiding this comment.
why not latest? 5.0.4
And we should target github, not their mirror on gitlab.
There was a problem hiding this comment.
good catch, updated in 7823421
There was a problem hiding this comment.
to avoid have to check for new version you can add .github/dependabot.yaml file like this one
version: 2
updates:
# GitHub actions dependencies
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
# Python dependencies (Optional)
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "weekly"There was a problem hiding this comment.
@kuisathaverat from what I can tell, dependabot doesn't support updating the pre-commit hook versions themselves: dependabot/dependabot-core#1524
There was a problem hiding this comment.
but keep GitHub Actions versions updated .github/workflows/pre-commit.yml
thanks @basepi for the heads-up
…ith-k8s-skaffold * upstream/main: bump python versions and use docker slim versions (elastic#1661) use github actions for pre-commit checks (elastic#1658) Use typing.TypeVar on decorators' type hints (elastic#1655) Use minimum of 5 seconds for interval between central config calls (elastic#1652) fix errors in pymongo tests introduced in elastic#1639 (elastic#1648) only use content-type and content-encoding headers for POSTing events (elastic#1651) fix starlette 0.21 tests (elastic#1653)
What does this pull request do?
Recently, a new release of
importlib-metadatabroke our pre-commit setup on Jenkins. The issue is that we runpre-commitin a Python 3.7 docker container. However, we can't use a more recent Python image, as that won't work with the deprecated pre-commit install script we use.When we had issues with pre-commit/linting the last time, we discussed using a Github Action instead. This PR implements this.