Add wrapper instrumentation for Django #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We instrument Apps.populate to insert our own app at the top of the list. This takes care of initialization. As Django requires a client of type DjangoClient, we can't initialize the client in sitecustomize already. Hence, we only load a limited config object to check enabled/instrument config values, and move client initialization into the actual instrumentation.
turns out we run into some fun corners of the Python object model, and fixing those would be much more involved than just some code duplication
basepi
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
This is great! Glad it was so easy.
As for testing, I'm a bit torn. I think right now this instrumentation is simple enough that we can probably skip an end to end test. But if for some reason this gets more complicated or brittle in the future, I think an end to end test (similar to the one I do for the wrapper script, where we actually shell out) would be worthwhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
We instrument
Apps.populateto insert our own app at the top of the list. This takes care of initialization.As Django requires a client of type DjangoClient, we can't initialize the client in sitecustomize already. Hence, we only load a limited config object to check enabled/instrument config values, and move client initialization into the actual instrumentation.
Related issues
Closes #1597
Ref #1709