add instrumentation for redis.asyncio #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basepi
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
This looks good. My only question (without having looked at the async redis code) is whether we should be using AsyncAbstractInstrumentedModule or awaiting any of these calls? Outside of the async_capture_span this module is not very async. That may be correct, especially with passing integration tests, but I wanted to point it out.
|
@basepi huh, great catch... I based this on the aioredis instrumentation, but obviously didn't look at it closely enough. I'll have to investigate, but this looks like the aioredis instrumentation was faulty to begin with. |
beniwohli
force-pushed
the
redis-asyncio-2
branch
from
fd6f661
to
51363fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
aioredis has been discontinued and moved into redis.asyncio, but with enough changes to warrant its own instrumentation.
Related issues
Closes #1799