New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lambda docs for lambda layer + docker image #1826
Conversation
I'm missing whatever is required to get the python layer showing up in the docs preview. Perhaps my |
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
@AlexanderWert The python agent ARNs are now showing up as Perhaps that's expected behavior in the preview? I don't know. |
I think that should be fixed once #1814 is merged and we have a release with a published Lambda layer. The replacement script looks up the latest Layer ARN version from the release table (here the example from Node.js: https://github.com/elastic/apm-agent-nodejs/releases/tag/v3.46.0). If it fails to look this up, it uses As we do not have a release with that table yet for Python, that's expected behavior. |
@AlexanderWert I was planning to put the release table in a collapsed block like this: Lambda Layer ARNsElastic APM Python agent layer ARNs
Do you think that will break your lookup script? I really like having our release notes uncluttered. Where is that script? |
This is the script: It basically parses the HTML of the page. But it seems the table is available in the HTML code even if it is collapsed, so it should work with your proposal as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can't really comment on the docs JS magic, not familiar with that part.
@@ -10,6 +10,7 @@ To get you off the ground, we’ve prepared guides for setting up the Agent with | |||
* <<starlette-support,Starlette/FastAPI>> | |||
* <<sanic-support,Sanic>> | |||
* <<lambda-support,AWS Lambda>> | |||
* <<azure-functions-support,Azure Functions>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
What does this pull request do?
Copies the structure of the lambda docs from the Node.js agent. I'm not sure if I missed any hooks, we'll have to check the docs build.
Related issues
Ref #1796 #1604
Depends on #1814 elastic/apm-aws-lambda#394