Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asyncpg tests to make it compatible with asyncpg>=0.29 #1935

Merged
merged 4 commits into from Nov 27, 2023
Merged

Fix asyncpg tests to make it compatible with asyncpg>=0.29 #1935

merged 4 commits into from Nov 27, 2023

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Nov 17, 2023 •
edited

What does this pull request do?

In asyncpg>=0.29, the query is passed as kwargs["state"] instead of as args.

MagicStack/asyncpg@cbf64e1

I'm not sure if all cases are tested, maybe there are untested cases to fix?

Related issues

Closes #1933

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Nov 17, 2023 •
edited

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Nov 17, 2023
@iurisilvio iurisilvio mentioned this pull request Nov 17, 2023
Closed
@iurisilvio iurisilvio force-pushed the fix-1933-asyncpg branch 3 times, most recently from 73acc0e to e06940d Compare November 18, 2023 09:21
basepi
basepi requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One small change below:

Edit: made the change myself because we need to get this merged so all the other PRs can go green.

@basepi basepi mentioned this pull request Nov 27, 2023
Closed
@basepi basepi requested a review from trentm November 27, 2023 22:36
@basepi basepi enabled auto-merge (squash) November 27, 2023 22:42
@basepi
Copy link
Contributor

basepi commented Nov 27, 2023

@elasticmachine, run elasticsearch-ci/docs

@basepi basepi merged commit 5ad3534 into elastic:main Nov 27, 2023
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with asyncpg 0.29.0
3 participants
@iurisilvio @basepi @trentm