Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make urlllib3 transport tests more robust against local env #1969

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Feb 15, 2024

What does this pull request do?

When mocking os.environ pass clear=True to avoid getting host configurations.

Related issues

Closes #1968

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Feb 15, 2024
When mocking os.environ pass clear=True to avoid getting host
configurations.

Fix elastic#1968
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@xrmx xrmx merged commit 6be16a4 into elastic:main Feb 16, 2024
86 checks passed
xrmx added a commit that referenced this pull request Mar 20, 2024
…1969)

When mocking os.environ pass clear=True to avoid getting host
configurations.

Fix #1968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy from environment variable transport tests fail
2 participants