Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/serverless/aws: normalize headers with v1 event format #1982

Merged
merged 1 commit into from Mar 5, 2024

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Mar 4, 2024

What does this pull request do?

If the event has been generated from elb or api gateway and is in the v1 format normalize headers even if they already should per https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

Event discrimination logic courtesy of nodejs apm client.

Related issues

Closes #1980

If the event has been generated from elb or api gateway and is in the
v1 format normalize headers even if they already should per
https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

Event discrimination logic courtesy of nodejs apm client.

Fix elastic#1980
@xrmx xrmx requested a review from basepi March 4, 2024 10:39
@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Mar 4, 2024
@xrmx xrmx requested a review from trentm March 4, 2024 10:40
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that I haven't tried it, nor have I learn this module ;)

@xrmx xrmx merged commit 0f5c531 into elastic:main Mar 5, 2024
97 checks passed
xrmx added a commit that referenced this pull request Mar 20, 2024
If the event has been generated from elb or api gateway and is in the
v1 format normalize headers even if they already should per
https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

Event discrimination logic courtesy of nodejs apm client.

Fix #1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing header normalization on AWS lambda
3 participants