ci: switch build-distribution downloadArtifact to v3 #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v4 can't find them if uploaded with uploadArtifact v3.
github-actions
bot
added
agent-python
community
pquentin
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
LGTM, but note that there are breaking changes between v3 and v4 (https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/)
I'm reverting to v3 because indeed v4 broke our release pipeline 😅 |
|
Ah right you're reverting to v3. Makes sense 👍 |
jackshirazi
approved these changes
Mar 8, 2024
xrmx
added a commit
that referenced
this pull request
Mar 20, 2024
Since v4 can't find them if uploaded with uploadArtifact v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Switch build-distribution downloadArtifact to v3 since v4 can't find artifacts if uploaded with uploadArtifact v3.
Related issues
https://github.com/elastic/apm-agent-python/actions/runs/8195374788/