handle StreamingHttpResponse correctly #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 24, 2018
elasticapm/contrib/django/apps.py
Outdated
| middleware_attr = 'MIDDLEWARE' if getattr(django_settings, 'MIDDLEWARE', None) is not None else 'MIDDLEWARE_CLASSES' | ||
| middleware = getattr(django_settings, middleware_attr) | ||
| return ((not django_settings.DEBUG or client.config.debug) and | ||
| middleware and 'elasticapm.contrib.django.middleware.TracingMiddleware' in middleware) |
There was a problem hiding this comment.
continuation line over-indented for visual indent
elasticapm/contrib/django/apps.py
Outdated
|
|
||
| request_started.disconnect(dispatch_uid=REQUEST_START_DISPATCH_UID) | ||
| request_started.connect( | ||
| lambda sender, environ, **kwargs: client.begin_transaction('request') if _should_start_transaction(client) else None, |
There was a problem hiding this comment.
line too long (125 > 120 characters)
beniwohli
force-pushed
the
transaction-start-signal
branch
from
b96e531
to
c061a69
Compare
beniwohli
changed the title
beniwohli
force-pushed
the
transaction-start-signal
branch
3 times, most recently
from
5a436c7
to
dd59261
Compare
…dlers This fixes issues with Django's StreamingHttpResponse, which is only consumed after passing through our TracingMiddleware. This also made some API changes necessary, to allow setting the transaction result before the end of the transaction, and allow to end the transaction without providing a result and name.
…dlers This fixes issues with Django's StreamingHttpResponse, which is only consumed after passing through our TracingMiddleware. This also made some API changes necessary, to allow setting the transaction result before the end of the transaction, and allow to end the transaction without providing a result and name.
This fixes issues with flask's streaming response, which is only consumed after the request_finished signal is called.
beniwohli
force-pushed
the
transaction-start-signal
branch
from
dd59261
to
5f52b83
Compare
beniwohli
added a commit
that referenced
this pull request
May 7, 2018
This fixes issues with flask's streaming response, which is only consumed after the request_finished signal is called. Django: moved starting/stopping of transaction into Django signal handlers This fixes issues with Django's StreamingHttpResponse, which is only consumed after passing through our TracingMiddleware. This also made some API changes necessary, to allow setting the transaction result before the end of the transaction, and allow to end the transaction without providing a result and name. closes #202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and (hopefully) fix for #201