Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added instrumentation for pymssql #241

Closed
wants to merge 1 commit into from
Closed

Added instrumentation for pymssql #241

wants to merge 1 commit into from

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Jun 25, 2018 •
edited by alvarolobato
Loading

fixes #239

@beniwohli
Copy link
Contributor Author

@eliasbrange would you mind giving this PR a quick test run? You can install it like so:

pip install "git+https://github.com/elastic/apm-agent-python.git@refs/pull/241/merge"

@eliasbrange
Copy link

I tried the instrumentation you wrote by adding to the source directly before which seemed to work. Can try installing the PR tomorrow!

@eliasbrange
Copy link

Thanks for adding this so quickly. Will make it much easier for me to demo APM.

@eliasbrange
Copy link

Seems to work good @beniwohli

@beniwohli
Copy link
Contributor Author

Awesome, thanks for testing it! I'll merge this and will do a release in the coming days (waiting for some feedback on the pyodbc instrumentation from another user).

Just as a FYI, we will be dropping support for Python 3.3 in the upcoming release, hope that doesn't affect you.

@beniwohli beniwohli closed this in d70f38b Jun 26, 2018
@beniwohli beniwohli deleted the pymssql-instrumentation branch June 26, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrumentation for PyMSSQL
2 participants
@beniwohli @eliasbrange