normalize HTTP status code in transaction.result #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
feature/http-transaction-result-normalization
branch
from
585144d
to
7b0e553
Compare
simitt
reviewed
Nov 3, 2017
| assert resp.status_code == 0, resp.response | ||
|
|
||
| transactions = flask_apm_client.client.instrumentation_store.get_all() | ||
| assert transactions[0]['result'] == '0 fail' # "0" is prepended by Werkzeug BaseResponse |
There was a problem hiding this comment.
Does this mean that every transaction.result not coming from a flask or django app has a 0 prefix no matter what? Could you get rid of this somehow?
There was a problem hiding this comment.
Not exactly. It means that if a flask user returns a non-integer HTTP status code (which is all kinds of wrong in the first place), flask will prepend this 0 to it. Not sure why, but I'm not hugely concerned about it, since it only happens when the user code doing something completely wrong
There was a problem hiding this comment.
oh yes, it is a flask test.. then I am with you to not worry about this too much.
simitt
approved these changes
Nov 3, 2017
beniwohli
force-pushed
the
feature/http-transaction-result-normalization
branch
2 times, most recently
from
a3660e4
to
dad4ff7
Compare
This normalizes the status code into status classes 2xx, 3xx, 4xx and 5xx. The unmodified status code is still available in context.response.status_code
beniwohli
force-pushed
the
feature/http-transaction-result-normalization
branch
from
dad4ff7
to
fffce0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This normalizes the status code into status classes 2xx, 3xx, 4xx and 5xx.
The unmodified status code is still available in context.response.status_code