New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rum-core): add apmRequest config typescript type #1254
Conversation
- add typescript support
💚 CLA has been signed |
/test |
Hi @ReneWerner87, Thanks for your contribution! TL;DR: The types have to be a bit different:
Context: When
On the case of the central config the arguments the agent provides are On the case of the events/beacons the |
- add typescript support
thx, i changed the types |
📦 Bundlesize report
|
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 , This will be part of the next release we do.
@hmdhk you had forgotten the typescript files, can you please check if it fits like this
the feature is great and we use it, thanks for your effort