perf(rum-core): avoid url parsing on resource timing entries #174
Conversation
packages/rum-core/src/performance-monitoring/capture-hard-navigation.js
Outdated
Show resolved
Hide resolved
packages/rum-core/src/performance-monitoring/performance-monitoring.js
Outdated
Show resolved
Hide resolved
|
@jahtalab Do you need me to change anything? Or shall i rebase and we can merge this? |
vigneshshanmugam
force-pushed
the
avoid-url-parse
branch
from
d9724e1
to
549b337
Compare
packages/rum-core/src/performance-monitoring/performance-monitoring.js
Outdated
Show resolved
Hide resolved
| /** | ||
| * Add context information when the span name and entry name are different | ||
| */ | ||
| if (spanName !== name) { |
There was a problem hiding this comment.
@vigneshshanmugam , I think we should consider this a breaking change since we're removing a field that users might have relied on!
There was a problem hiding this comment.
I am not sure here, I don't have any numbers on how much users search for context in kibana search UI. What we can do is to split this change and do in separate PR and not combine with this performance optimisation.
There was a problem hiding this comment.
I think generally we should keep in mind how each change affects the users, since we're open source we might never know some of the use-cases!
Yeah, let's split to avoid having multiple changes in the same PR.
…#174) * perf(rum-core): avoid url parsing on resource timing entries * filter null values * add context by defauly
Resource timing entries name have fully resolved URL as part of the SPEC and we dont really need to parse them again based on the window base URL.
The context information is sent only when the Entry Name is different from Span name -> Happens when the resource contains query strings in URL. small optimisation for reducing the payload to APM server.