-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backoff mechanism to recover from APM Server transport failures #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
reviewed
Mar 16, 2022
felixbarny
reviewed
Mar 16, 2022
felixbarny
reviewed
Mar 16, 2022
felixbarny
reviewed
Mar 16, 2022
felixbarny
reviewed
Mar 17, 2022
felixbarny
approved these changes
Mar 18, 2022
felixbarny
reviewed
Mar 18, 2022
jlvoiseux
commented
Mar 18, 2022
jlvoiseux
commented
Mar 18, 2022
jlvoiseux
commented
Mar 18, 2022
estolfo
reviewed
Mar 18, 2022
estolfo
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and I'm approving but I have just a few minor comments.
jlvoiseux
commented
Mar 21, 2022
jlvoiseux
commented
Mar 21, 2022
jlvoiseux
commented
Mar 21, 2022
estolfo
requested changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor request
estolfo
approved these changes
Mar 22, 2022
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Summary
This PR aims to implement a backoff mechanism to recover from APM Server transport failures, due to the APM server being unavailable. To meet this goal, the mechanism described in issue #131 is implemented.
Changes
In
apm_server.go
, a simple finiste state machine is implemented. The states are as follows :nominal
: in this state, the extension is able to send APM data without any issue.failure
: we enter this state upon detection of a transport error. In this state, no data is sent to the APM server (the data is queued back into the dedicated channel).waitingForNextAttempt
: upon detection of a transport error, a timer (defined according to the APM Transport spec) is started. When it ends, this state is used to signal to the extension that it can try again to send data to the APM server.Pending questions
ELASTIC_APM_DATA_FORWARDER_TIMEOUT_SECONDS
config option.