Fix benchmark tf module with python function #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lahsivjar
commented
Sep 29, 2023
lahsivjar
commented
- Adds support for using lambda layer in the terraform module.
- Fix extension zip path resolution.
- Update python lambda instrumentation to use lambda layer.
lahsivjar
commented
Sep 29, 2023
| @@ -96,10 +96,10 @@ func (c *Client) FlushAPMData(ctx context.Context) { | |||
| } | |||
|
|
|||
| // Flush lambda data | |||
| c.logger.Debug("Flush in progress - Processing lambda data") | |||
There was a problem hiding this comment.
[For reviewers] This log line led to a lot of noise during flush. Moved it so that only single entry is logged per flush.
carsonip
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.