Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

fix: update chrome and pm2 to fix unhealthy rum instance #270

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

vigneshshanmugam
Copy link
Member

pm2 daemon was not getting killed after doing these two changes,

  • Memory and CPU was not bound, So if the issue continues to appear we need to either increase the timeout of health check for this specific image.

@vigneshshanmugam
Copy link
Member Author

Can anyone help here why the CI is failing? Doesn't seem to be related to the change. @graphaelli @kuisathaverat

@kuisathaverat
Copy link
Contributor

kuisathaverat commented Jan 17, 2019

The APM server is not started correctly, in those cases, you can relaunch the job to see if it is consistent in that job it is not easy to relaunch the job, pipeline will resolve it, the workaround it is to make a simple change in the PR to force to rebuild, I think is not related too.

ERROR: for apm-server  Container "34e0b7b79b03" is unhealthy.

@vigneshshanmugam
Copy link
Member Author

@kuisathaverat Sure Thanks, I have done a dummy commit to trigger build

@graphaelli
Copy link
Member

jenkins, retest this please

Copy link
Member

@graphaelli graphaelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good and work locally for me. Is there a good docker healthcheck we can add to the rum instance?

@vigneshshanmugam
Copy link
Member Author

@graphaelli right now it goes to the default path and we are using the default timeout for the healthcheck. Probably we can run healthcheck on another port just to keep the instance running without getting killed by race between load gen and healthcheck on same port.

@graphaelli
Copy link
Member

jenkins, retest this please

@graphaelli
Copy link
Member

graphaelli commented Jan 18, 2019

@vigneshshanmugam now that CI is actually able to run the services, the failures indicate this was branched before a few fixes went in. I've merged master in and pushed to your branch, I hope you don't mind. We should squash merge when this is ready to go.

Also, please disregard my comment about the healthcheck, I was referring to the rum agent container (used by integration tests) and this only changes the opbeans rum container.

@vigneshshanmugam
Copy link
Member Author

@graphaelli Thanks a lot for taking care of the broken build.. Sure no problem 👍. I will squash and merge the PR now.

@vigneshshanmugam vigneshshanmugam merged commit 31b8ab7 into master Jan 21, 2019
@vigneshshanmugam vigneshshanmugam deleted the fix-rum-image branch January 21, 2019 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants