-
Notifications
You must be signed in to change notification settings - Fork 71
fix: update chrome and pm2 to fix unhealthy rum instance #270
Conversation
Can anyone help here why the CI is failing? Doesn't seem to be related to the change. @graphaelli @kuisathaverat |
The APM server is not started correctly, in those cases,
|
@kuisathaverat Sure Thanks, I have done a dummy commit to trigger build |
jenkins, retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good and work locally for me. Is there a good docker healthcheck we can add to the rum instance?
@graphaelli right now it goes to the default path and we are using the default timeout for the healthcheck. Probably we can run healthcheck on another port just to keep the instance running without getting killed by race between load gen and healthcheck on same port. |
jenkins, retest this please |
@vigneshshanmugam now that CI is actually able to run the services, the failures indicate this was branched before a few fixes went in. I've merged master in and pushed to your branch, I hope you don't mind. We should squash merge when this is ready to go. Also, please disregard my comment about the healthcheck, I was referring to the rum agent container (used by integration tests) and this only changes the opbeans rum container. |
@graphaelli Thanks a lot for taking care of the broken build.. Sure no problem 👍. I will squash and merge the PR now. |
chrome is changed from stable - unstable.. https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-in-docker
have updated pm2 to latest because of PM2 Daemon is dead Unitech/pm2#3266 (comment).
pm2 daemon was not getting killed after doing these two changes,