This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
feat: return the exit code of docker compose in case of failure #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
approved these changes
Mar 25, 2020
cachedout
approved these changes
Mar 25, 2020
This was referenced Mar 25, 2020
sorenlouv
approved these changes
Mar 25, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It waits for the return code of the docker-compose command and raises an exception if it is no equal 0.
Why is it important?
The current behavior does not check the return code if the command fails, the exit code of
compose.pyis 0 in any case.Related issues
Closes #800