Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return the exit code of docker compose in case of failure #803

Merged
merged 1 commit into from Mar 25, 2020

Conversation

@kuisathaverat
Copy link
Contributor

kuisathaverat commented Mar 25, 2020

What does this PR do?

It waits for the return code of the docker-compose command and raises an exception if it is no equal 0.

Why is it important?

The current behavior does not check the return code if the command fails, the exit code of compose.py is 0 in any case.

Related issues

Closes #800

@kuisathaverat kuisathaverat requested review from sqren and elastic/observablt-robots Mar 25, 2020
@kuisathaverat kuisathaverat self-assigned this Mar 25, 2020
@sqren
sqren approved these changes Mar 25, 2020
@sqren sqren mentioned this pull request Mar 25, 2020
2 of 2 tasks complete
@kuisathaverat kuisathaverat merged commit 4c4c30d into elastic:master Mar 25, 2020
4 checks passed
4 checks passed
CLA All commits passed the check
Details
Sanity checks Sanity checks passed
Details
Unit Tests Unit Tests passed
Details
apm-ci/pr-merge This commit looks good
Details
@kuisathaverat kuisathaverat deleted the kuisathaverat:return-code branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.