Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

fix: do not back-off on intake req errors in Lambda env #180

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix: do not back-off on intake req errors in Lambda env #180

merged 1 commit into from
Mar 10, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 9, 2022 •
edited
Loading

Doing the back-off in a Lambda env can result in the APM agent instrumentation breaking the Lambda function response: elastic/apm-agent-nodejs#2598
See the inline comment and the motivation at: elastic/apm#613

commit message

fix: do not back-off on intake req errors in Lambda env

Refs: https://github.com/elastic/apm-agent-nodejs/issues/2598
Refs: https://github.com/elastic/apm/pull/613

@trentm trentm requested a review from astorm March 9, 2022 23:47
@trentm trentm self-assigned this Mar 9, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 9, 2022
@trentm trentm added this to Planned in APM-Agents (OLD) via automation Mar 9, 2022
@trentm trentm moved this from Planned to In Progress in APM-Agents (OLD) Mar 9, 2022
@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-09T23:48:02.062+0000

  • Duration: 8 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 287
Skipped 0
Total 287

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@felixbarny felixbarny mentioned this pull request Mar 10, 2022
Closed
4 tasks
astorm
astorm approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 approved

@trentm trentm merged commit 59a9d93 into main Mar 10, 2022
@trentm trentm deleted the trentm/fix-ext-down-response-null branch March 10, 2022 21:57
APM-Agents (OLD) automation moved this from In Progress to Done Mar 10, 2022
@trentm trentm mentioned this pull request Mar 10, 2022
Closed
trentm added a commit to elastic/apm-agent-nodejs that referenced this pull request Mar 10, 2022
@trentm
fix: if Lambda extension is down, agent eventually causes null functi…
9e172dc 
…on response

This updates to get http-client fix
elastic/apm-nodejs-http-client#180

Fixes: #2598
@trentm trentm mentioned this pull request Mar 10, 2022
Merged
4 tasks
trentm added a commit to elastic/apm-agent-nodejs that referenced this pull request Mar 15, 2022
@trentm
fix: if Lambda extension is down, agent eventually causes null functi…
96559d8 
…on response (#2608)

This updates to get http-client fix
elastic/apm-nodejs-http-client#180

Fixes: #2598
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@astorm astorm astorm approved these changes

Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trentm @apmmachine @astorm