Skip to content

Commit

Permalink
index span.db.link as keyword
Browse files Browse the repository at this point in the history
  • Loading branch information
jalvz committed Aug 1, 2019
1 parent 6b5d204 commit cb56ca5
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 2 deletions.
11 changes: 11 additions & 0 deletions docs/fields.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -1195,6 +1195,17 @@ type: boolean
--
*`span.db.link`*::
+
--
Database link.
type: keyword
--
[[exported-fields-apm-transaction]]
== APM Transaction fields
Expand Down
1 change: 1 addition & 0 deletions docs/spec/spans/span.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
},
"link": {
"type": ["string", "null"],
"maxLength": 1024,
"description": "Database link"
},
"statement": {
Expand Down
2 changes: 1 addition & 1 deletion include/fields.go

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion model/span/_meta/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
fields:

- name: id
type: keyword
type: keyword
description: >
The ID of the span stored as hex encoded string.
Expand Down Expand Up @@ -52,3 +52,12 @@
description: >
Indicates whether the span was executed synchronously or asynchronously.
- name: db
type: group
dynamic: false
fields:

- name: link
type: keyword
description: >
Database link.
1 change: 1 addition & 0 deletions model/span/generated/schema/span.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ const ModelSchema = `{
},
"link": {
"type": ["string", "null"],
"maxLength": 1024,
"description": "Database link"
},
"statement": {
Expand Down
1 change: 1 addition & 0 deletions processor/stream/package_tests/span_attrs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ func TestKeywordLimitationOnSpanAttrs(t *testing.T) {
{Template: "parent.id", Mapping: "parent_id"},
{Template: "trace.id", Mapping: "trace_id"},
{Template: "span.id", Mapping: "id"},
{Template: "span.db.link", Mapping: "context.db.link"},
{Template: "span.", Mapping: ""},
},
)
Expand Down

0 comments on commit cb56ca5

Please sign in to comment.