Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beater/middleware: update fields to be ECS-compliant #3796

Closed
axw opened this issue May 14, 2020 · 1 comment
Closed

beater/middleware: update fields to be ECS-compliant #3796

axw opened this issue May 14, 2020 · 1 comment
Assignees
@simitt

Comments

@axw
Copy link
Member

axw commented May 14, 2020

We should update the logging middleware to use ECS-compliant field names and values:

apm-server/beater/middleware/log_middleware.go

Line 34 in c0f4767

func LogMiddleware() Middleware {

"method" -> "http.method", "URL" -> "http.url", etc.
@axw axw mentioned this issue May 14, 2020
Merged
4 tasks
@simitt simitt self-assigned this May 14, 2020
@simitt simitt mentioned this issue May 25, 2020
Merged
4 tasks
@simitt
Copy link
Contributor

simitt commented May 28, 2020

Depends on elastic/beats#18820

simitt added a commit to simitt/apm-server that referenced this issue May 28, 2020
@simitt
Ensure ECS compliant logging when enabled.
ee97961 
If `logging.ecs` is set log data in ECS compliant way.

closes elastic#3796
simitt added a commit to simitt/apm-server that referenced this issue May 28, 2020
@simitt
Ensure ECS compliant logging when enabled.
30a0a7e 
If `logging.ecs` is set log data in ECS compliant way.

closes elastic#3796
@simitt simitt mentioned this issue May 28, 2020
Merged
5 tasks
simitt added a commit to simitt/apm-server that referenced this issue Jun 16, 2020
@simitt
Ensure ECS compliant logging when enabled.
8479620 
If `logging.ecs` is set log data in ECS compliant way.

closes elastic#3796
@zube zube bot closed this as completed Jun 17, 2020
@zube zube bot reopened this Jun 17, 2020
@simitt simitt closed this as completed in 3787214 Dec 15, 2020
simitt added a commit to simitt/apm-server that referenced this issue Dec 15, 2020
@simitt
Ensure ECS compliant logging when enabled. (elastic#3829)
6f1dc86 
If `logging.ecs` is set log data in ECS compliant way.

closes elastic#3796
simitt added a commit that referenced this issue Dec 15, 2020
@simitt
[7.x] Ensure ECS compliant logging when enabled. (#3829) (#4536)
c5bde23 
If `logging.ecs` is set log data in ECS compliant way.

closes #3796
@axw axw removed the [zube]: Done label Dec 24, 2020
@simitt simitt mentioned this issue Dec 28, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axw @simitt