Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTel Collector dependency >= 0.56.0 #8576

Closed
AlexanderWert opened this issue Jul 11, 2022 · 4 comments · Fixed by #8765
Closed

Update OTel Collector dependency >= 0.56.0 #8576

AlexanderWert opened this issue Jul 11, 2022 · 4 comments · Fixed by #8765

Comments

@AlexanderWert
Copy link
Member

AlexanderWert commented Jul 11, 2022

OpenTelemetry Swift introduced in version 1.3 changes that require OTel Collector version >= 0.56.0.

As a consequence the iOS APM agent cannot update to OpenTelemetry Swift versions > 1.2.0 as long as we do not update the corresponding OTel collector dependency in the APM server. This can become a blocker for new features and important updates we depend on in OpenTelemetry Swift.

We need to update the go.opentelemetry.io/collector/* dependencies to the latest version (or at least something >= 0.56.0).

Since nearly every release on the OTel collector repository has breaking changes it's not clear whether an update of the collector dependencies would break some behavior for older OTel agents / OTLP intake formats. Some investigation and testing is needed for this.

@AlexanderWert
Copy link
Member Author

@bryce-b Looks like current version of opentelemetry-swift does not work with the newest versions of the collector either:
open-telemetry/opentelemetry-swift#311

Could you please verify this / or test with collector 0.55.0, so that we know which version of the collector dependency we would need to update the APM server to?

Thanks!

@simitt simitt modified the milestone: 8.5 Jul 27, 2022
@simitt simitt modified the milestones: 8.4, 8.5 Jul 27, 2022
@simitt
Copy link
Contributor

simitt commented Jul 27, 2022

@elastic/apm-server let's wait for @bryce-b investigation which collector version is reliable before updating.

@bryce-b
Copy link
Contributor

bryce-b commented Jul 28, 2022

I spun up the demo otel-collector in the opentelemetry-collector-contrib which runs v0.56.0 of the collector. I was able to successfully capture traces using the latest version of opentelemetry-swift (v1.1.4)

Screencap on a trace captured in zipkin.
Screen Shot 2022-07-28 at 3 19 20 PM

@simitt simitt changed the title Update OTel Collector dependency Update OTel Collector dependency >= 0.56.0 Jul 29, 2022
@simitt
Copy link
Contributor

simitt commented Jul 29, 2022

Updated the description and title to reflect an update to 0.56.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants