Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy client.ip to source.ip #2771

Merged
merged 3 commits into from Oct 8, 2019
Merged

Copy client.ip to source.ip #2771

merged 3 commits into from Oct 8, 2019

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Oct 4, 2019 •
edited

Ensure to populate the source.ip field whenever possibel in alignment
with ECS.

fixes #2766

@simitt
Copy client.ip to source.ip
37f4516 
Ensure to populate the `source.ip` field whenever possibel in alignment
with ECS.

fixes elastic#2766
@codecov-io
Copy link

codecov-io commented Oct 4, 2019 •
edited

Codecov Report

Merging #2771 into master will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2771      +/-   ##
==========================================
+ Coverage   79.63%   80.03%   +0.39%     
==========================================
  Files          84       83       -1     
  Lines        4611     4592      -19     
==========================================
+ Hits         3672     3675       +3     
+ Misses        939      917      -22
Impacted Files Coverage Δ
agentcfg/fetch.go 87.87% <0%> (-4.81%) ⬇️
beater/api/config/agent/handler.go 94.44% <0%> (-4.16%) ⬇️
agentcfg/model.go 91.3% <0%> (-2.58%) ⬇️
beater/api/mux.go 70.96% <0%> (-0.47%) ⬇️
beater/middleware/cors_middleware.go 100% <0%> (ø) ⬆️
utility/ip.go 100% <0%> (ø) ⬆️
model/metadata/user.go 100% <0%> (ø) ⬆️
beater/api/intake/handler.go 100% <0%> (ø) ⬆️
beater/middleware/rum_middleware.go
model/transaction/event.go 95.45% <0%> (+0.27%) ⬆️
... and 5 more

@simitt simitt added the review label Oct 4, 2019
@simitt simitt requested a review from jalvz October 4, 2019 14:14
graphaelli
graphaelli reviewed Oct 4, 2019
View reviewed changes
changelogs/head.asciidoc Outdated Show resolved Hide resolved
@graphaelli
Copy link
Member

Did you decide we don't want to geoip process this in source.geo?

@simitt
Copy link
Contributor Author

simitt commented Oct 7, 2019

Afaik it is not needed for any visualization, so I suggest to not enable it and duplicate data (for now).

@simitt simitt merged commit f87f8d3 into elastic:master Oct 8, 2019
simitt added a commit to simitt/apm-server that referenced this pull request Oct 9, 2019
@simitt
Copy client.ip to source.ip (elastic#2771)
1b73f15 
Ensure to populate the `source.ip` field whenever possibel in alignment
with ECS.

fixes elastic#2766
@simitt simitt mentioned this pull request Oct 9, 2019
Merged
simitt added a commit to simitt/apm-server that referenced this pull request Oct 9, 2019
@simitt
Copy client.ip to source.ip (elastic#2771)
4526d32 
Ensure to populate the `source.ip` field whenever possibel in alignment
with ECS.

fixes elastic#2766
simitt added a commit that referenced this pull request Oct 9, 2019
@simitt
Copy client.ip to source.ip (#2771) (#2786)
85f31f1 
Ensure to populate the `source.ip` field whenever possibel in alignment
with ECS.

fixes #2766
@simitt simitt deleted the 2766-fill-source_ip branch October 11, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphaelli graphaelli graphaelli left review comments

@jalvz jalvz jalvz approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy client.ip address to source.ip address for SIEM integration
4 participants
@simitt @codecov-io @graphaelli @jalvz