all: propagate context through Transformables #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a context.Context parameter to the Transformable interface, and update all implementations and callers. This enables us to connect the sourcemap calls in error and span events to be traced.
simitt
approved these changes
Mar 20, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Mar 22, 2020
* all: propagate context through Transformables We add a context.Context parameter to the Transformable interface, and update all implementations and callers. This enables us to connect the sourcemap calls in error and span events to be traced. * Update changelog
axw
added a commit
that referenced
this pull request
Mar 23, 2020
* all: propagate context through Transformables We add a context.Context parameter to the Transformable interface, and update all implementations and callers. This enables us to connect the sourcemap calls in error and span events to be traced. * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
We add a
context.Contextparameter to thetransform.Transformableinterface, and update all implementations and callers, propagating context from the publisher through the Transform calls.This enables us to connect the sourcemap calls in error and span events to be traced.
Checklist
make check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] New and existing unit tests pass locally with my changesHow to test these changes
Screenshots
Related issues
None.