rename in_app to library_frame, reversing meaning #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvz
approved these changes
Dec 8, 2017
simitt
approved these changes
Dec 8, 2017
model/stacktrace_frame.go
Outdated
| @@ -13,7 +13,7 @@ type StacktraceFrame struct { | |||
| ContextLine *string `mapstructure:"context_line"` | |||
| Module *string | |||
| Function *string | |||
| InApp *bool `mapstructure:"in_app"` | |||
| InLibrary *bool `mapstructure:"library_frame"` | |||
There was a problem hiding this comment.
I'd prefer to also call it LibraryFrame here as it is more consistent.
There was a problem hiding this comment.
I was trying to avoid repeating Frame, as in StackFrame.LibraryFrame but looking at it again I don't think it's a big deal and will change it.
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Dec 13, 2017
* rename in_app to library_frame, reversing meaning closes elastic#384 * InLibrary -> LibraryFrame per feedback
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Dec 13, 2017
* rename in_app to library_frame, reversing meaning closes elastic#384 * InLibrary -> LibraryFrame per feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #384