Support dropped span_count on transactions. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work @simitt. I think it would be useful to add the field to |
roncohen
approved these changes
Jan 4, 2018
|
I was thinking about indexing it, but decided against it as the UI doesn't need it. But giving it a second thought it is probably worth to be indexed. |
Adds count to index. closes elastic#280.
|
jenkins, retest this please. |
Closed
3 tasks
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jan 8, 2018
Adds count to index. closes elastic#280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #280.