Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transaction.name optional. #554

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jan 26, 2018

Remove attribute from minimal testfiles.
implements #425

@elastic/apm-agent-devs fyi

@simitt simitt force-pushed the enhancement-optional-transaction-name branch 2 times, most recently from d1c53be to b1549ef Compare January 29, 2018 08:49
@simitt simitt force-pushed the enhancement-optional-transaction-name branch from b1549ef to 71578f6 Compare January 29, 2018 09:14
@simitt simitt merged commit b5b584e into elastic:master Jan 29, 2018
simitt added a commit to simitt/apm-server that referenced this pull request Jan 29, 2018
Remove attribute from minimal testfiles.
implements elastic#425
simitt added a commit to simitt/apm-server that referenced this pull request Jan 29, 2018
Remove attribute from minimal testfiles.
implements elastic#425
simitt added a commit to simitt/apm-server that referenced this pull request Jan 31, 2018
Remove attribute from minimal testfiles.
implements elastic#425
@watson
Copy link
Contributor

watson commented Jan 31, 2018

@simitt which Elastic version will this be included in?

simitt added a commit to simitt/apm-server that referenced this pull request Jan 31, 2018
Remove attribute from minimal testfiles.
implements elastic#425
simitt added a commit that referenced this pull request Jan 31, 2018
Remove attribute from minimal testfiles.
implements #425
@simitt
Copy link
Contributor Author

simitt commented Jan 31, 2018

@watson 6.3.

@watson watson added the v6.3 label Jan 31, 2018
@simitt simitt deleted the enhancement-optional-transaction-name branch February 13, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants