Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original values when transforming. #647

Merged
merged 3 commits into from
Feb 8, 2018

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Feb 7, 2018

Persist original values when

  • applying source mapping
  • setting library_frame indicator
    by storing original values within original namespace.

Ensure transform operation is idempotent,
by using original values if applied multiple times.

implements #566

Persist original values when
* applying source mapping
* setting library_frame indicator
by storing original values within `original` namespace.

Ensure transform operation is idempotent,
by using original values if applied multiple times.

implements elastic#566
Copy link
Contributor

@jalvz jalvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt look into failing ci (some detail i guess) but overall lgtm

@simitt
Copy link
Contributor Author

simitt commented Feb 8, 2018

jenkins, retest this please.

@simitt simitt merged commit 1432fce into elastic:master Feb 8, 2018
simitt added a commit to simitt/apm-server that referenced this pull request Feb 8, 2018
* Keep original values when transforming.

Persist original values when
* applying source mapping
* setting library_frame indicator
by storing original values within `original` namespace.

Ensure transform operation is idempotent,
by using original values if applied multiple times.
@simitt simitt deleted the enhancement-keep-orig-values branch February 13, 2018 14:47
simitt added a commit to simitt/apm-server that referenced this pull request Feb 21, 2018
* Keep original values when transforming.

Persist original values when
* applying source mapping
* setting library_frame indicator
by storing original values within `original` namespace.

Ensure transform operation is idempotent,
by using original values if applied multiple times.
simitt added a commit that referenced this pull request Feb 21, 2018
* Keep original values when transforming.

Persist original values when
* applying source mapping
* setting library_frame indicator by storing original 
values within `original` namespace.

Ensure transform operation is idempotent,
by using original values if applied multiple times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants