Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span links to intake v2 #7553

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Add span links to intake v2 #7553

merged 3 commits into from
Mar 18, 2022

Conversation

axw
Copy link
Member

@axw axw commented Mar 16, 2022

Motivation/summary

Add support for span links to intake v2, for spans and transactions. I have intentionally not added support to the RUM v3 intake, as there is no need for span links there at present.

Checklist

How to test these changes

  1. Send testdata/intake-v2/span-links.ndjson to apm-server
  2. Check the spans and transactions indexed in Elasticsearch have span.links fields populated accordingly

Related issues

Closes #7304

@apmmachine
Copy link
Collaborator

apmmachine commented Mar 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-17T17:12:48.812+0000

  • Duration: 51 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 4397
Skipped 14
Total 4411

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2022

This pull request does not have a backport label. Could you fix it @axw? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 16, 2022
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note that I just looked at the spec json files

@axw axw marked this pull request as ready for review March 17, 2022 01:03
@axw axw requested a review from a team March 17, 2022 01:04
@axw axw enabled auto-merge (squash) March 17, 2022 08:01
@axw axw disabled auto-merge March 17, 2022 09:38
@axw axw enabled auto-merge (squash) March 17, 2022 09:38
@stuartnelson3
Copy link
Contributor

/test

@stuartnelson3
Copy link
Contributor

confirmed with 4575383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-ok v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define intake schema for span links
6 participants