-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sniff Content-Encoding, don't require Content-Type #7686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
stuartnelson3
approved these changes
Mar 29, 2022
kruskall
pushed a commit
to kruskall/apm-server
that referenced
this pull request
Jul 11, 2023
* decoder: sniff Content-Encoding * api/intake: don't require Content-Type * Update changelog
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
/intake
; assumeapplication/x-ndjson
if not specified.Checklist
- [ ] Update package changelog.yml (only if changes toapmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
Send a variety of requests to APM Server, checking that they are all accepted:
Content-Encoding
unspecified, uncompressed bodyContent-Encoding
unspecified, gzip-compressed bodyContent-Encoding
unspecified, deflate-compressed bodyContent-Encoding: gzip
, gzip-compressed bodyContent-Encoding: deflate
, deflate-compressed bodyContent-Type
unspecifiedContent-Type: application/x-ndjson
Check that these requests are rejected:
Content-Type: invalid
Content-Encoding: invalid
Related issues
Closes #7271