Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3 Bucket and Object Key to S3 instrumentation (OTel) #788

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Add S3 Bucket and Object Key to S3 instrumentation (OTel) #788

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19bc9f9
chore: add OTel attributes s3.bucket and s3.key for AWS spec
david-luna Apr 21, 2023
34e2df6
chore: fix typo in table
david-luna Apr 26, 2023
4b855ce
chore: improve formatting in bucket attrib name
david-luna Apr 26, 2023
82fbc5e
chore: improve formatting in key attrib name
david-luna Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specs/agents/tracing-instrumentation-db.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ The following fields are relevant for database and datastore spans. Where possib
| __**service.target._**__ |<hr/>|<hr/>|
|`_.type`| `s3` ||
|`_.name`| e.g. `my-bucket`, `accesspoint/myendpointslashes`, or `accesspoint:myendpointcolons` | The bucket name, if available. The s3 API allows either the bucket name or an Access Point to be provided when referring to a bucket. Access Points can use either slashes or colons. When an Access Point is provided, the access point name preceded by accesspoint/ or accesspoint: should be extracted. For example, given an Access Point such as `arn:aws:s3:us-west-2:123456789012:accesspoint/myendpointslashes`, the agent extracts `accesspoint/myendpointslashes`. Given an Access Point such as `arn:aws:s3:us-west-2:123456789012:accesspoint:myendpointcolons`, the agent extracts `accesspoint:myendpointcolons`. |
| __**otel.attributes._**__ |<hr/>|<hr/>|
|`_.aws.s3.bucket`| `my-bucket` | The bucket name, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/semantic_conventions/trace/instrumentation/aws-sdk.yml#L435). |
|`_.aws.s3.key`| `my/key/path` | The S3 object key, if applicable. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.20.0/semantic_conventions/trace/instrumentation/aws-sdk.yml#L435). |

### Cassandra

Expand Down