Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcase for k8s parsing #837

Merged
merged 1 commit into from Nov 28, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Nov 20, 2023

Found while investigating some customer issues with the Java agent elastic/apm-agent-java#3418.

The parsing of the container ID used to include the containerd- prefix, which is not something that is expected. As a consequence including it in the shared tests helps to prevent this issue from happening with other agents.

I have also seen this in practice in the data collected on ES clusters in Elastic Cloud, while it has been reported when using the "gardener" k8s tool, this might also apply to other similar tools.


  • May the instrumentation collect sensitive information, such as secrets or PII (ex. in headers)?
    • n/a: it just updates an automated test data
  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Approved by at least 2 agents + PM (if relevant)
  • Merge after 7 days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.
  • Create implementation issues through the meta issue template (this will automate issue creation for individual agents) will be implicit through the spec sync PRs on each impacted agent.

@trentm
Copy link
Member

trentm commented Nov 21, 2023

the "gardener" k8s tool

https://gardener.cloud/ apparently.

@SylvainJuge SylvainJuge marked this pull request as ready for review November 22, 2023 08:29
@SylvainJuge SylvainJuge requested review from a team November 27, 2023 08:55
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SylvainJuge SylvainJuge merged commit 2792af0 into elastic:main Nov 28, 2023
5 checks passed
@SylvainJuge SylvainJuge deleted the gardener-containerid branch November 28, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants